HDDS-10320. Introduce factory to configure MiniOzoneCluster's datanodes #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
changed the title
errose28
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Thanks for the improvement @adoroszlai LGTM. Just a question: in the future how would we implement a factory or factories to make a cluster with different datanode configurations?
By refactoring the current implementation as needed: extracting methods to be overridden, etc. The factory interface can also be implemented from scratch. We will need to expose parts of the current implementation for reuse. |
|
Thanks @errose28 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently MiniOzoneCluster creates almost identical datanodes, based on global config and few datanode-specific properties:
numDataVolumesdatanodeReservedSpacednLayoutVersionThis change introduces a factory to create datanodes for
MiniOzoneCluster, further cleaning up the globalMiniOzoneCluster.Builderinterface.Other implementations can be added in the future to customize each datanode (e.g. different number of volumes, different amount of reserved space, etc.).
https://issues.apache.org/jira/browse/HDDS-10320
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7979189177