HDDS-10612. Add Robot test to verify Container Balancer for RATIS containers #6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtutrinov
reviewed
Apr 1, 2024
hadoop-ozone/dist/src/main/compose/ozone-balancer/docker-compose.yaml
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Thanks @afilpp for the patch. Overall looks good, added some minor comments.
It would be nice to create the environment as an add-on for ozone-ha instead of a completely separate one, but we can check if it's feasible in a follow-up task.
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Apr 1, 2024
myskov
approved these changes
Apr 2, 2024
|
Seems there is an intermittent failure on the acceptance test https://github.com/apache/ozone/actions/runs/8546730074/job/23418032793 @afilpp Could you take a look? Edit: Can refer to the comment in HDDS-10612 for possible root cause. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…tainers (apache#6457) (cherry picked from commit 129cdc1)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Sep 16, 2024
…tainers (apache#6457) (cherry picked from commit 129cdc1)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Sep 18, 2024
…tainers (apache#6457) (cherry picked from commit 129cdc1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-10612. Add Robot test to verify Container Balancer for RATIS containers
Currently there are only unit tests for Container Balancer and no acceptance tests at all. At a minimum, we should add a Robot test to verify Container Balancer for RATIS containers. And probably in the future we should add robot test for EC case.
Test case:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10612
How was this patch tested?
Added Robot test