-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-11105. Generate Robot report in container #6951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downloaded acceptance artifacts from CI run and checked log.html:
This worked earlier too right ? I think the test should be to locally run a robot test via test-single.sh
Yes. However GitHub's runner doesn't have Robot Framework installed, we used to install it (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adoroszlai for the patch, LGTM.
Thanks @sadanand48 for the review. |
What changes were proposed in this pull request?
compose/testlib.sh
runs Robot tests in Docker containers. However, it tries to generate test reports locally, which assumes Robot Framework is installed on the host. It fails ifrebot
is not found, even if all tests pass.acceptance.sh
installs Robot Framework if it's not already available. Therefore it can assume the commandrebot
is available for report generation.To simplify local use of acceptance tests,
testlib.sh
could generate reports in anozone-runner
container, similarly to how tests are executed. Thus we can avoid the need to install Robot Framework.https://issues.apache.org/jira/browse/HDDS-11105
How was this patch tested?
Downloaded acceptance artifacts from CI run and checked
log.html
:https://github.com/adoroszlai/ozone/actions/runs/9953554917