HDDS-3250. Create a separate log file for Warnings and Errors in MiniOzoneChaosCluster. #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OzoneChaosCluster.
|
The changes looks good to me, one thing that we may consider is naming as the errorfilename covers something which contains warns errors and fatals which was surprising for the first sight, but thinking it through it is reasonable, and I don't have a better name in the current context :) |
adoroszlai
approved these changes
Mar 24, 2020
hadoop-ozone/fault-injection-test/mini-chaos-tests/src/test/resources/log4j.properties
Outdated
Show resolved
Hide resolved
isahkemat
pushed a commit
to isahkemat/hadoop-ozone
that referenced
this pull request
Mar 29, 2020
…OzoneChaosCluster. (apache#711)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding a new log file for just the error while running MiniOzoneChaosCluster
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3250
How was this patch tested?
Ran MiniOzoneChaosCluster