Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose #7121

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

jojochuang
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose

Please describe your PR in detail:

  1. Removed @flaky annotation from TestBlockOutputStreamWithFailures#testContainerClose and TestBlockOutputStream#testWriteMoreThanMaxFlushSize
  2. Relaxed the assertions in the test to match the current behavior.
  3. Verified there's no longer intermittent test failures in TestBlockOutputStreamWithFailures#testContainerClose and TestBlockOutputStream#testWriteMoreThanMaxFlushSize

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11325

How was this patch tested?

Flaky-test-check:

https://github.com/jojochuang/ozone/actions/runs/10532241331
TestBlockOutputStream#testWriteMoreThanMaxFlushSize[HDDS-11325-take2]-10x10

https://github.com/jojochuang/ozone/actions/runs/10565349000
TestBlockOutputStreamWithFailures#testContainerClose[HDDS-11325-take2]-10x10

…#testContainerClose (addendum)

Change-Id: I169b5767af8eb8b0ad93f9bf5b12dd6b9845b1da
Change-Id: I16b1c28af7ad6bea2414ac8577f2c0a5aeaf6e7e
@jojochuang jojochuang changed the title HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose HDDS-11325. (addendum) Intermittent failure in TestBlockOutputStreamWithFailures#testContainerClose Aug 26, 2024
@jojochuang
Copy link
Contributor Author

It failed in CI at a later location. This one might indicate product issue actually.

Error:  Tests run: 24, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 29.049 s <<< FAILURE! - in org.apache.hadoop.ozone.client.rpc.TestBlockOutputStream
Error:  org.apache.hadoop.ozone.client.rpc.TestBlockOutputStream.testWriteMoreThanFlushSize(boolean, boolean)[3]  Time elapsed: 0.053 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <250> but was: <50>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:166)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:161)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:632)
	at org.apache.hadoop.ozone.client.rpc.TestBlockOutputStream.testWriteMoreThanFlushSize(TestBlockOutputStream.java:539)

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jojochuang for the patch.

@adoroszlai adoroszlai merged commit 3bd237d into apache:master Aug 28, 2024
28 of 29 checks passed
@adoroszlai
Copy link
Contributor

Thanks @jojochuang for the patch, @smengcl for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants