Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[WIP] Various OsX fixes #6

Closed
wants to merge 7 commits into from
Closed

[WIP] Various OsX fixes #6

wants to merge 7 commits into from

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Mar 23, 2015

No description provided.

@kashif kashif changed the title Various OsX fixes [WIP] Various OsX fixes Mar 23, 2015
@wesm
Copy link
Member

wesm commented Dec 24, 2015

Hi @kashif; I didn't see your patch before undertaking #13; perhaps we can collaborate and get the OS X code fixes (outside the cmake / build toolchain changes)

@kashif
Copy link
Contributor Author

kashif commented Dec 24, 2015

sure @wesm would love to look at it. I am currently away for xmas but will ping you when I am back home?

@wesm
Copy link
Member

wesm commented Jan 21, 2016

@kashif this patch has been subsumed by PARQUET-416 and PARQUET-267. However, we need to update the Thrift headers. Opening a JIRA for that:

https://issues.apache.org/jira/browse/PARQUET-449

@kashif
Copy link
Contributor Author

kashif commented Jan 21, 2016

@wesm sure I can have a look at that if you like?

@wesm
Copy link
Member

wesm commented Jan 21, 2016

Please do!

@wesm
Copy link
Member

wesm commented Jan 22, 2016

I propose we close this PR -- I opened a JIRA about OS X compiler warnings here https://issues.apache.org/jira/browse/PARQUET-455. See also #15

@kashif kashif closed this Jan 22, 2016
@julienledem
Copy link
Member

@wesm you can add closes #6 in the description of your pr to close the corresponding PR if a change supersedes them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants