Fix varint-encode() encoding algorithm link #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec says that varint-encode() is ULEB-128 encoding but links to VLQ algorithm that is slightly different from ULEB-128
|
LGTM. Can you create a JIRA and update the PR title? https://issues.apache.org/jira/browse/PARQUET |
|
I created PARQUET-1032 for this. @kostya-sh - Do you want to pick this back up? |
lekv
pushed a commit
to lekv/parquet-format
that referenced
this pull request
Jul 31, 2017
…evels Added a LevelDecoder and LevelEncoder class to read and write batches of def/rep levels. Added tests to verify the functionality. Author: Deepak Majeti <deepak.majeti@hp.com> Closes apache#30 from majetideepak/master and squashes the following commits: 18d7e51 [Deepak Majeti] fixed argument order of asserts inside test cases 5e0000b [Deepak Majeti] PARQUET-169: Implement support for reading repetition and definition levels
|
It has been a long time but I have created #69 with the updated commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec says that varint-encode() is ULEB-128 encoding but links to VLQ algorithm that is slightly different from ULEB-128