-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PARQUET-2468: ParquetMetadata must convert to json #1349
Conversation
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. I have left some minor comments. Mostly LGTM.
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
Show resolved
Hide resolved
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ParquetMetadata.java
Show resolved
Hide resolved
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/StatisticsSerializer.java
Outdated
Show resolved
Hide resolved
8a1053f
to
976b7c2
Compare
976b7c2
to
1146006
Compare
@JsonIgnore | ||
public InternalFileDecryptor getFileDecryptor() { | ||
return fileDecryptor; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When logging the file metadata, we probably want to skip this
"fileDecryptor" : {
"fileAAD" : null,
"decryptionProperties" : {
"footerKey" : "AQIDBAUGBwgJCgsMDQ4PEA==",
"keyRetriever" : null,
"aadprefix" : null
}
},
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ColumnChunkMetaData.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @RustedBones, this makes sense to me 👍
Thanks for the reply! @Fokko It seems that we need a minor release for this. +1 on my side. |
ParquetMetadata
json serialization failed onUNENCRYPTED
files.Add required configuration to the metadata
ObjectMaper
:FAIL_ON_EMPTY_BEANS
to serialize LogicalTypeAnnotation (was removed in Remove old setting for cascading #1144)Optional
typeAlso add custom serializer for
Statistics