feat: support Eureka discovery #242
Conversation
Roiocam
force-pushed
the
eureka-discovery
branch
from
685423e
to
a31e2b8
Compare
...hon-api/src/main/scala/org/apache/pekko/discovery/marathon/MarathonApiServiceDiscovery.scala
Outdated
Show resolved
Hide resolved
...ery-eureka/src/test/scala/org/apache/pekko/discovery/eureka/EurekaServiceDiscoverySpec.scala
Outdated
Show resolved
Hide resolved
| # default discovery service group. | ||
| group-name = "DEFAULT_GROUP" | ||
| # default eureka registration status page url | ||
| status-page-url = "" |
There was a problem hiding this comment.
@Roiocam most of these configs are unused - can we remove the unused ones?
| "work for defaults" in { | ||
| val lookupService = new EurekaServiceDiscovery() | ||
| val resolved = lookupService.lookup("BANK-ACCOUNT", 10.seconds).futureValue | ||
| resolved.addresses should contain( |
There was a problem hiding this comment.
With the changes that I have committed, the embeddedEurekaServer is starting and can be contacted.
The response for this test though is:
[ERROR] [09/23/2024 15:16:35.239] [test-pekko.actor.default-dispatcher-5] [EurekaServiceDiscovery(pekko://test)] Failed to unmarshal Eureka response status [404 Not Found], entity: [{
"servlet":"default",
"message":"Not Found",
"url":"/eureka/apps/BANK-ACCOUNT",
"status":"404"
}], uri: [http://127.0.0.1:53003/eureka/apps/BANK-ACCOUNT]
There was a problem hiding this comment.
did they register it on startup? or you has been loaded in Eureka server
There was a problem hiding this comment.
I changed the test to pre-register the BANK-ACCOUNT application.
I found the responses from embedded-eureka did not match the classes that were set up for Spry-JSON binding.
I made changes to make the tests pass. Feel free to add back functionality that I removed but ideally, the tests would be kept up to date so that they continue to pass.
|
Unfortunately, embedded-eureka needs java 11. |
what about testcontainers? |
https://github.com/Netflix/eureka