Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sbt-pull-request-validator #1067

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Jan 28, 2024

@mdedetrich knows

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - pending CI (the link validator issue is not caused by this change)

@He-Pin
Copy link
Member

He-Pin commented Jan 28, 2024

@mkurz
Copy link
Contributor Author

mkurz commented Jan 28, 2024

can be merged I guess.

@pjfanning pjfanning merged commit 7bf26c8 into apache:main Jan 28, 2024
17 of 18 checks passed
@pjfanning
Copy link
Contributor

I'll back port this to the 1.0.x branch later

@mkurz mkurz deleted the sbt-pull-request-validator branch January 28, 2024 16:10
pjfanning pushed a commit to pjfanning/incubator-pekko that referenced this pull request Jan 28, 2024
He-Pin pushed a commit that referenced this pull request Jan 28, 2024
Co-authored-by: Matthias Kurz <m.kurz@irregular.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants