Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for tcp register timeout leaving connection dead #1183

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented Mar 7, 2024

Refs #1182

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @pjfanning @Roiocam @He-Pin @jxnu-liguobin @raboof Should also take a look

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning
Copy link
Contributor

maybe in some further iteration, we could look at retries - but this is an improvement as is

@pjfanning pjfanning added this to the 1.1.0-M1 milestone Mar 7, 2024
@laglangyue
Copy link
Contributor

LGTM

@nvollmar
Copy link
Contributor Author

nvollmar commented Mar 7, 2024

I was thinking going the other direction and questioning the need for the Register message.
As far as I could see from a quick search, the Register is always sent by the same actor that opens the connections.

So do we need to have that capability to have a different handler? Or could we inline everything into the connection open and avoid having that timeout entirely?

It also seems to be a really really rare case since it usually only takes milliseconds (receiving the message and replying back). We only ever saw that in case of a test environment we use in low power mode and deploy a complete system to it.

Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need to investigate deeper. ❤️

@He-Pin
Copy link
Member

He-Pin commented Mar 7, 2024

I will TAL at weekend, a little busy at $Work

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as it was supervised by org.apache.pekko.pattern.BackoffSupervisor.

@mdedetrich
Copy link
Contributor

Got enough approvals, merging so it can get released with M1

@mdedetrich mdedetrich merged commit fa5c83f into apache:main Mar 9, 2024
18 checks passed
@nvollmar nvollmar deleted the 1182-tcp-register-timeout branch March 12, 2024 09:24
@pjfanning pjfanning added late-release-note late breaking changes that will require release notes changes and removed late-release-note late breaking changes that will require release notes changes labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants