upgrade to jackson 2.17 #1318
Merged
upgrade to jackson 2.17 #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
May 7, 2024
•
pjfanning
commented
- the bugs in jackson 2.17.0 have been fixed
- review Jackson 2.17 when issues are resolved #1202
This was referenced May 7, 2024
pjfanning
requested review from
He-Pin,
raboof,
nvollmar,
mdedetrich,
Roiocam and
jxnu-liguobin
raboof
reviewed
May 7, 2024
| @@ -1,5 +1,5 @@ | |||
| updates.pin = [ | |||
| { groupId = "com.fasterxml.jackson.core", version = "2.16." } | |||
| { groupId = "com.fasterxml.jackson.core", version = "2.17." } | |||
There was a problem hiding this comment.
I think it is best to keep them for now. Upgrades in jackson have proved to be complicated in the past.
| @@ -62,7 +62,7 @@ pekko.serialization.jackson { | |||
| } | |||
|
|
|||
| write { | |||
| # see https://www.javadoc.io/static/com.fasterxml.jackson.core/jackson-core/2.16.2/com/fasterxml/jackson/core/StreamWriteConstraints.html | |||
| # see https://www.javadoc.io/static/com.fasterxml.jackson.core/jackson-core//com/fasterxml/jackson/core/StreamWriteConstraints.html | |||
There was a problem hiding this comment.
Suggested change
| # see https://www.javadoc.io/static/com.fasterxml.jackson.core/jackson-core//com/fasterxml/jackson/core/StreamWriteConstraints.html | |
| # see https://www.javadoc.io/static/com.fasterxml.jackson.core/jackson-core/2.17.1/com/fasterxml/jackson/core/StreamWriteConstraints.html |
There was a problem hiding this comment.
thanks - I created #1320
He-Pin
reviewed
May 7, 2024
| @@ -62,7 +62,7 @@ pekko.serialization.jackson { | |||
| } | |||
|
|
|||
| write { | |||
| # see https://www.javadoc.io/static/com.fasterxml.jackson.core/jackson-core/2.16.2/com/fasterxml/jackson/core/StreamWriteConstraints.html | |||
| # see https://www.javadoc.io/static/com.fasterxml.jackson.core/jackson-core//com/fasterxml/jackson/core/StreamWriteConstraints.html | |||
There was a problem hiding this comment.
thanks - I created #1320
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.