chore: migrate tests to flatten supervise API #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roiocam
changed the title
Roiocam
force-pushed
the
migrate-to-new-api
branch
from
e36a234
to
e9c5edb
Compare
pjfanning
reviewed
Aug 18, 2024
actor-typed-tests/src/test/scala/org/apache/pekko/actor/typed/SupervisionSpec.scala
Show resolved
Hide resolved
Roiocam
commented
Aug 19, 2024
| LoggingTestKit.error[Exc3].expect { | ||
| spawn(behv) | ||
| } | ||
| } | ||
|
|
||
| "support nesting exceptions with different strategies" in { | ||
| def throwIOExceptionThenIllegalArgumentException(behvFactory: ActorRef[Event] => Behavior[Command]): Unit = { |
There was a problem hiding this comment.
"support nesting exceptions with outer restart and inner backoff strategies" in {
and
"support nesting exceptions with different strategies" in {
almost same, Therefore, it is compressed into the same method here
Roiocam
force-pushed
the
migrate-to-new-api
branch
from
dde6473
to
fc4b0c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue #1386, separate PR for test migration