Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncurried stream ops in javadsl #1407

Open
wants to merge 1 commit into
base: 1.0.x
Choose a base branch
from

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Jul 21, 2024

(cherry picked from commit f9ad446)

Since this change has been determined to be completely safe (see #1406 (comment) and thread in general) I think its a good candidate to cherry pick back to the 1.0.x series since if we ever do another release in the 1.0.x series it will mean that the docs/source/syntax completion will be better

(cherry picked from commit f9ad446)
@He-Pin
Copy link
Member

He-Pin commented Jul 21, 2024

I think we better keep it in 1.1.x, @pjfanning ,wdyt? I don't have strong option on this.

@pjfanning
Copy link
Contributor

I'd prefer to hold off on this. Can we focus on getting 1.1.0 released?

@mdedetrich
Copy link
Contributor Author

I'd prefer to hold off on this. Can we focus on getting 1.1.0 released?

Well reviewing/merging this isn't going to have an impact on 1.1.0 one way or another

Regarding 1.1.0, I am not sure if there was a discussion on the release plan (I have been a bit out of the loop as of late), or more specifically is the idea that we are meant to wait for a bit just to be sure that its stable (we are currently using 1.1.0-M1 in production), if so its best to wait to get feedback from a critical amount of users.

@pjfanning
Copy link
Contributor

I'd prefer to hold off on this. Can we focus on getting 1.1.0 released?

Well reviewing/merging this isn't going to have an impact on 1.1.0 one way or another

Regarding 1.1.0, I am not sure if there was a discussion on the release plan (I have been a bit out of the loop as of late), or more specifically is the idea that we are meant to wait for a bit just to be sure that its stable (we are currently using 1.1.0-M1 in production), if so its best to wait to get feedback from a critical amount of users.

My point is that we have been very conservative with 1.0.x changes. I would prefer not to merge this to 1.0.x. We can have the 1.1.0 release discussion on the mailing list. There are a few open issues but we could probably consider releasing 1.1.0-M2 soon or even doing 1.1.0 instead.

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Jul 21, 2024

My point is that we have been very conservative with 1.0.x changes. I would prefer not to merge this to 1.0.x.

Sure, but conservative doesn't mean "none at all" and at least currently without these changes, for cross Java/Scala projects the effected parts in javadsl is currently broken when it comes to IDE's syntax highlighting and considering that it has zero impact on bytecode (and people are using 1.0.x) I think that this should pass the bar, we have certainly merged things into 1.0.x on a lot less than this.

Lets keep the 1.1.0 release discussion out of this issue, there wasn't any reason to bring it up as it has nothing to do with this.

@He-Pin
Copy link
Member

He-Pin commented Jul 22, 2024

I'm not using Kotlin with pekko-stream, but the current one works ok with Java, even with Java21, do you have a screenshot where is cause problem when work with Kotlin @mdedetrich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants