Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add onErrorComplete stream operator. #913

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Jan 7, 2024

refs: #624

@He-Pin He-Pin added this to the 1.1.0 milestone Jan 7, 2024
@He-Pin He-Pin force-pushed the onErrorComplete branch 2 times, most recently from d5231e0 to 0e6561e Compare January 7, 2024 10:38
@He-Pin He-Pin requested a review from pjfanning January 7, 2024 10:41
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - but would like to see more reviews before it is merged

Copy link
Member

@jxnu-liguobin jxnu-liguobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@He-Pin He-Pin merged commit 2b3818b into apache:main Jan 7, 2024
18 checks passed
@He-Pin He-Pin deleted the onErrorComplete branch January 7, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants