Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest sbt-osgi #920

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Jan 9, 2024

Resolves: #757 . See sbt/sbt-osgi#102 (comment) . I have tested that this works with pekko-http using

sbt -Dpekko.build.pekko.version=1.1.0-M0-SNAPSHOT "++ 2.12.18" Test/compile
sbt -Dpekko.http.parallelExecution=false -Dpekko.test.timefactor=2 -Dpekko.build.pekko.version=1.1.0-M0-SNAPSHOT "++ 2.12.18" mimaReportBinaryIssues test

where 1.1.0-M0-SNAPSHOT is a version I manually set for this PR.

Copy link
Contributor

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich
Copy link
Contributor Author

Ill go ahead and merge this so we can iron out any regressions

@mdedetrich mdedetrich merged commit b9d2cc6 into apache:main Jan 9, 2024
18 checks passed
@mdedetrich mdedetrich deleted the use-latest-version-of-sbt-osgi branch January 9, 2024 18:00
@mdedetrich
Copy link
Contributor Author

I can confirm that this is working correctly, the latest pekko-http nightly builds passed without issues (see https://github.com/apache/incubator-pekko-http/actions/runs/7469468687)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use newer sbt-osgi for main branch
3 participants