Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6419 Unused getResolverForQuery() in QueryCompiler.verifySCN() #1174

Closed
wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Mar 19, 2021

No description provided.

@virajjasani virajjasani added the backport Backport PR label Mar 19, 2021
@stoty
Copy link
Contributor Author

stoty commented Mar 19, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 13m 52s 4.x passed
+1 💚 compile 1m 4s 4.x passed
+1 💚 checkstyle 0m 34s 4.x passed
+1 💚 javadoc 0m 50s 4.x passed
+0 🆗 spotbugs 3m 8s phoenix-core in 4.x has 944 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 47s the patch passed
+1 💚 compile 1m 2s the patch passed
+1 💚 javac 1m 2s the patch passed
-1 ❌ checkstyle 0m 33s phoenix-core: The patch generated 2 new + 331 unchanged - 3 fixed = 333 total (was 334)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 46s the patch passed
+1 💚 spotbugs 3m 47s phoenix-core generated 0 new + 943 unchanged - 1 fixed = 943 total (was 944)
_ Other Tests _
+1 💚 unit 138m 30s phoenix-core in the patch passed.
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
176m 22s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1174/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1174
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 6b5ae5beeaf8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / e6d7d0b
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1174/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1174/1/testReport/
Max. process+thread count 5965 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1174/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for catching this @stoty

@stoty stoty closed this Mar 19, 2021
@stoty stoty deleted the PHOENIX-6419-4.x branch July 29, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants