Add more tests for PHOENIX-6247 #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
gjacoby126
reviewed
Apr 8, 2021
| try (HBaseAdmin admin = conn.unwrap(PhoenixConnection.class).getQueryServices() | ||
| .getAdmin()) { | ||
|
|
||
| assertEquals(false, admin.tableExists(TableName.valueOf(fullTableHName))); |
There was a problem hiding this comment.
Aren't you already doing this check in test_bothTableAndIndexHaveDifferentNames which you just called?
There was a problem hiding this comment.
You are right. Removing
|
|
||
| // Drop row and check | ||
| conn.createStatement().execute("ALTER TABLE " + fullTableName + " DROP COLUMN NEW_COLUMN_1"); | ||
|
|
There was a problem hiding this comment.
Looks like we drop but don't check as the comment says we will? Or is the lack of an exception the only check we need here?
There was a problem hiding this comment.
Will update the comment. Yes lack of exception
gokceni
force-pushed
the
separatePhysical2
branch
from
b8a8fcd
to
15c3106
Compare
|
💔 -1 overall
This message was automatically generated. |
mnpoonia
reviewed
Apr 14, 2021
| @@ -973,6 +976,25 @@ private PTable getTable(byte[] tenantId, byte[] schemaName, byte[] tableName, lo | |||
| return table; | |||
| } | |||
|
|
|||
| private PName getPhysicalTableName(Region region, byte[] tenantId, byte[] schema, byte[] table, long timestamp) throws IOException { | |||
There was a problem hiding this comment.
You think adding this to SchemaUtil make any sense. I see a lot of implementation of getPhysicalTableName there
|
Thanks @gokceni. Is PR against master branch open? |
|
@virajjasani I merged all of these on master and 4.x Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.