Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6351 PhoenixMRJobUtil getActiveResourceManagerAddress logic f… #1214

Merged
merged 1 commit into from
May 3, 2021

Conversation

richardantal
Copy link
Contributor

…ails on pseudodistributed cluster

Change-Id: Id6c2382a6bac888c65900e8f0327d07c8a9e6fd0

…ails on pseudodistributed cluster

Change-Id: Id6c2382a6bac888c65900e8f0327d07c8a9e6fd0
@stoty
Copy link
Contributor

stoty commented Apr 28, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 32s master passed
+0 hbaserecompile 22m 17s HBase recompiled.
+1 💚 compile 1m 6s master passed
+1 💚 checkstyle 0m 34s master passed
+1 💚 javadoc 0m 50s master passed
+0 🆗 spotbugs 3m 7s phoenix-core in master has 960 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 8m 4s the patch passed
+0 hbaserecompile 17m 26s HBase recompiled.
+1 💚 compile 1m 1s the patch passed
+1 💚 javac 1m 1s the patch passed
+1 💚 checkstyle 0m 34s phoenix-core: The patch generated 0 new + 69 unchanged - 3 fixed = 69 total (was 72)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 50s the patch passed
+1 💚 spotbugs 3m 15s the patch passed
_ Other Tests _
-1 ❌ unit 117m 14s phoenix-core in the patch failed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
173m 10s
Reason Tests
Failed junit tests phoenix.end2end.PermissionsCacheIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1214/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1214
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux 3f60aedf516b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / e9de744
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1214/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1214/1/testReport/
Max. process+thread count 15207 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1214/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Copy link
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@richardantal richardantal merged commit 55aeb15 into apache:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants