Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6454: Add feature to SchemaTool to get the DDL in specificati… #1229

Merged
merged 1 commit into from
May 14, 2021

Conversation

swaroopak
Copy link
Contributor

…on mode (#1217)

Co-authored-by: Swaroopa Kadam s.kadam@apache.org

@stoty
Copy link
Contributor

stoty commented May 13, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 4m 58s Maven dependency ordering for branch
+1 💚 mvninstall 11m 50s master passed
+0 hbaserecompile 24m 12s HBase recompiled.
+1 💚 compile 1m 34s master passed
+1 💚 checkstyle 1m 0s master passed
+1 💚 javadoc 1m 12s master passed
+0 🆗 spotbugs 3m 7s phoenix-core in master has 960 extant spotbugs warnings.
+0 🆗 spotbugs 0m 44s phoenix-tools in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 30s root in the patch failed.
+0 hbaserecompile 7m 55s HBase recompiled.
-1 ❌ compile 0m 21s phoenix-core in the patch failed.
-1 ❌ compile 0m 16s phoenix-tools in the patch failed.
-1 ❌ javac 0m 21s phoenix-core in the patch failed.
-1 ❌ javac 0m 16s phoenix-tools in the patch failed.
-1 ❌ checkstyle 0m 38s phoenix-core: The patch generated 32 new + 208 unchanged - 3 fixed = 240 total (was 211)
-1 ❌ checkstyle 0m 24s phoenix-tools: The patch generated 185 new + 221 unchanged - 41 fixed = 406 total (was 262)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 1m 11s the patch passed
-1 ❌ spotbugs 0m 18s phoenix-core in the patch failed.
-1 ❌ spotbugs 0m 15s phoenix-tools in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 19s phoenix-core in the patch failed.
-1 ❌ unit 0m 16s phoenix-tools in the patch failed.
+1 💚 asflicense 0m 29s The patch does not generate ASF License warnings.
50m 45s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1229
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux f89f9d51463c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / df32aec
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-tools.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/testReport/
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: phoenix-core phoenix-tools U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented May 13, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 4m 56s Maven dependency ordering for branch
+1 💚 mvninstall 12m 44s master passed
+0 hbaserecompile 24m 40s HBase recompiled.
+1 💚 compile 1m 39s master passed
+1 💚 checkstyle 0m 53s master passed
+1 💚 javadoc 1m 13s master passed
+0 🆗 spotbugs 3m 25s phoenix-core in master has 960 extant spotbugs warnings.
+0 🆗 spotbugs 0m 42s phoenix-tools in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 32s root in the patch failed.
+0 hbaserecompile 10m 18s HBase recompiled.
-1 ❌ compile 0m 22s phoenix-core in the patch failed.
-1 ❌ compile 0m 31s phoenix-tools in the patch failed.
-1 ❌ javac 0m 22s phoenix-core in the patch failed.
-1 ❌ javac 0m 31s phoenix-tools in the patch failed.
-1 ❌ checkstyle 0m 55s phoenix-core: The patch generated 32 new + 208 unchanged - 3 fixed = 240 total (was 211)
-1 ❌ checkstyle 0m 24s phoenix-tools: The patch generated 157 new + 249 unchanged - 13 fixed = 406 total (was 262)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 1m 27s the patch passed
-1 ❌ spotbugs 0m 20s phoenix-core in the patch failed.
-1 ❌ spotbugs 0m 33s phoenix-tools in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 21s phoenix-core in the patch failed.
-1 ❌ unit 0m 34s phoenix-tools in the patch failed.
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
55m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1229
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux d216818e5e73 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / df32aec
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-compile-phoenix-tools.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-tools.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/testReport/
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: phoenix-core phoenix-tools U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented May 14, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 1s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 6m 8s Maven dependency ordering for branch
+1 💚 mvninstall 13m 16s master passed
+0 hbaserecompile 27m 28s HBase recompiled.
+1 💚 compile 1m 33s master passed
+1 💚 checkstyle 0m 54s master passed
+1 💚 javadoc 1m 9s master passed
+0 🆗 spotbugs 3m 21s phoenix-core in master has 965 extant spotbugs warnings.
+0 🆗 spotbugs 0m 42s phoenix-tools in master has 3 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 9m 48s the patch passed
+0 hbaserecompile 16m 43s HBase recompiled.
+1 💚 compile 1m 35s the patch passed
+1 💚 javac 1m 35s the patch passed
-1 ❌ checkstyle 0m 39s phoenix-core: The patch generated 43 new + 359 unchanged - 9 fixed = 402 total (was 368)
-1 ❌ checkstyle 0m 19s phoenix-tools: The patch generated 166 new + 249 unchanged - 13 fixed = 415 total (was 262)
-1 ❌ whitespace 0m 0s The patch 2 line(s) with tabs.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 10s the patch passed
-1 ❌ spotbugs 0m 57s phoenix-tools generated 5 new + 0 unchanged - 3 fixed = 5 total (was 3)
_ Other Tests _
-1 ❌ unit 128m 49s phoenix-core in the patch failed.
-1 ❌ unit 4m 48s phoenix-tools in the patch failed.
-1 ❌ asflicense 1m 44s The patch generated 1 ASF License warnings.
200m 46s
Reason Tests
FindBugs module:phoenix-tools
Found reliance on default encoding in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String):in org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String): new java.io.FileReader(File) At SchemaSynthesisProcessor.java:[line 212]
org.apache.phoenix.schema.SchemaSynthesisProcessor.getQueriesFromFile(String) may fail to close stream At SchemaSynthesisProcessor.java:stream At SchemaSynthesisProcessor.java:[line 212]
org.apache.phoenix.schema.SchemaTool.conf should be package protected In SchemaTool.java: In SchemaTool.java
Possible null pointer dereference of cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:cmdLine in org.apache.phoenix.schema.SchemaTool.parseOptions(String[]) Dereferenced at SchemaTool.java:[line 114]
Write to static field org.apache.phoenix.schema.SchemaTool.conf from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:from instance method org.apache.phoenix.schema.SchemaTool.run(String[]) At SchemaTool.java:[line 73]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1229
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml
uname Linux 3c1c37373577 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 877457e
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/whitespace-tabs.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-tools.html
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/testReport/
asflicense https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count 8265 (vs. ulimit of 30000)
modules C: phoenix-core phoenix-tools U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1229/3/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak swaroopak merged commit eeebc8e into apache:master May 14, 2021
richardantal pushed a commit to richardantal/phoenix-1 that referenced this pull request Jul 22, 2021
…on mode (apache#1229)

Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
richardantal pushed a commit that referenced this pull request Jul 29, 2021
…on mode (#1229)

Co-authored-by: Swaroopa Kadam <s.kadam@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants