Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6498 Fix incorrect Correlated Exists Subquery rewrite when Su… #1268

Closed
wants to merge 5 commits into from

Conversation

comnetwork
Copy link
Contributor

…bquery is aggregate

@stoty
Copy link
Contributor

stoty commented Jul 16, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
+1 💚 mvninstall 18m 13s 4.x passed
+1 💚 compile 1m 1s 4.x passed
+1 💚 checkstyle 0m 35s 4.x passed
+1 💚 javadoc 0m 46s 4.x passed
+0 🆗 spotbugs 3m 0s phoenix-core in 4.x has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 9m 50s the patch passed
+1 💚 compile 1m 2s the patch passed
+1 💚 javac 1m 2s the patch passed
-1 ❌ checkstyle 0m 35s phoenix-core: The patch generated 60 new + 294 unchanged - 43 fixed = 354 total (was 337)
-1 ❌ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 javadoc 0m 44s the patch passed
+1 💚 spotbugs 3m 12s the patch passed
_ Other Tests _
+1 💚 unit 207m 49s phoenix-core in the patch passed.
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
252m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1268
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 2b8718e17ccd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 4215de3
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/1/artifact/yetus-general-check/output/whitespace-eol.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/1/testReport/
Max. process+thread count 5024 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jul 16, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
+1 💚 mvninstall 18m 21s 4.x passed
+1 💚 compile 1m 2s 4.x passed
+1 💚 checkstyle 0m 35s 4.x passed
+1 💚 javadoc 0m 45s 4.x passed
+0 🆗 spotbugs 3m 2s phoenix-core in 4.x has 954 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 9m 42s the patch passed
+1 💚 compile 1m 3s the patch passed
+1 💚 javac 1m 2s the patch passed
-1 ❌ checkstyle 0m 35s phoenix-core: The patch generated 60 new + 294 unchanged - 43 fixed = 354 total (was 337)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 46s the patch passed
+1 💚 spotbugs 3m 11s the patch passed
_ Other Tests _
+1 💚 unit 208m 51s phoenix-core in the patch passed.
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
249m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1268
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 971b4df12b26 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 4215de3
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/2/testReport/
Max. process+thread count 5319 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jul 26, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 9m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
+1 💚 mvninstall 22m 8s 4.x passed
+1 💚 compile 1m 12s 4.x passed
+1 💚 checkstyle 0m 36s 4.x passed
+1 💚 javadoc 0m 52s 4.x passed
+0 🆗 spotbugs 3m 40s phoenix-core in 4.x has 956 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 14m 30s the patch passed
+1 💚 compile 1m 14s the patch passed
+1 💚 javac 1m 14s the patch passed
-1 ❌ checkstyle 0m 40s phoenix-core: The patch generated 60 new + 294 unchanged - 43 fixed = 354 total (was 337)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 52s the patch passed
+1 💚 spotbugs 4m 3s the patch passed
_ Other Tests _
-1 ❌ unit 214m 46s phoenix-core in the patch failed.
+1 💚 asflicense 0m 51s The patch does not generate ASF License warnings.
277m 48s
Reason Tests
Failed junit tests phoenix.end2end.AuditLoggingIT
phoenix.monitoring.PhoenixMetricsIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1268
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 87ee617772df 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / a681594
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/3/testReport/
Max. process+thread count 4746 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/3/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jul 27, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
+1 💚 mvninstall 18m 41s 4.x passed
+1 💚 compile 1m 1s 4.x passed
+1 💚 checkstyle 0m 36s 4.x passed
+1 💚 javadoc 0m 46s 4.x passed
+0 🆗 spotbugs 3m 0s phoenix-core in 4.x has 956 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 9m 46s the patch passed
+1 💚 compile 1m 2s the patch passed
+1 💚 javac 1m 2s the patch passed
-1 ❌ checkstyle 0m 35s phoenix-core: The patch generated 48 new + 291 unchanged - 46 fixed = 339 total (was 337)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 42s the patch passed
+1 💚 spotbugs 3m 14s the patch passed
_ Other Tests _
+1 💚 unit 213m 36s phoenix-core in the patch passed.
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
258m 30s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1268
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux d1ae6eab523f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / a681594
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/4/testReport/
Max. process+thread count 5664 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/4/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Jul 28, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
+1 💚 mvninstall 18m 11s 4.x passed
+1 💚 compile 1m 2s 4.x passed
+1 💚 checkstyle 0m 36s 4.x passed
+1 💚 javadoc 0m 47s 4.x passed
+0 🆗 spotbugs 3m 3s phoenix-core in 4.x has 956 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 9m 45s the patch passed
+1 💚 compile 1m 2s the patch passed
+1 💚 javac 1m 2s the patch passed
-1 ❌ checkstyle 0m 36s phoenix-core: The patch generated 48 new + 291 unchanged - 46 fixed = 339 total (was 337)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 44s the patch passed
+1 💚 spotbugs 3m 12s the patch passed
_ Other Tests _
-1 ❌ unit 218m 7s phoenix-core in the patch failed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
261m 25s
Reason Tests
Failed junit tests phoenix.end2end.UpsertSelectIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1268
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 8fe263458cf0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 42e97fc
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/5/testReport/
Max. process+thread count 5914 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1268/5/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Apr 25, 2023

The 4.x branch is EOL.
This fix has been merged to master and 5.1

@stoty stoty closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants