Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-6543 de-flake AuditLoggingIT #1302

Closed
wants to merge 2 commits into from
Closed

PHOENIX-6543 de-flake AuditLoggingIT #1302

wants to merge 2 commits into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Sep 14, 2021

No description provided.

richardantal
richardantal reviewed Sep 14, 2021
View reviewed changes
phoenix-core/src/it/java/org/apache/phoenix/end2end/AuditLoggingIT.java Outdated
assertEquals(rs2.getString(7), selectQuery);
assertFalse(rs2.next());
break;
} catch (AssertionFailedError e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we catch AssertionError instead of AssertionFailedError?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you are right.
Fixed.

@stoty
Copy link
Contributor Author

stoty commented Sep 14, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 30m 6s master passed
+0 hbaserecompile 39m 37s HBase recompiled.
+1 💚 compile 1m 28s master passed
+1 💚 checkstyle 1m 18s master passed
+1 💚 javadoc 1m 16s master passed
+0 🆗 spotbugs 4m 18s phoenix-core in master has 972 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 23m 47s the patch passed
+0 hbaserecompile 37m 50s HBase recompiled.
+1 💚 compile 1m 37s the patch passed
+1 💚 javac 1m 37s the patch passed
+1 💚 checkstyle 1m 20s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 1m 10s the patch passed
+1 💚 spotbugs 4m 31s the patch passed
_ Other Tests _
-1 ❌ unit 158m 47s phoenix-core in the patch failed.
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
255m 43s
Reason Tests
Failed junit tests phoenix.end2end.index.IndexMetadataIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1302
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux 58d61de4c478 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / e84232b
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/1/testReport/
Max. process+thread count 6223 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor Author

stoty commented Sep 14, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 13s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 20m 57s master passed
+0 hbaserecompile 27m 43s HBase recompiled.
+1 💚 compile 1m 3s master passed
+1 💚 checkstyle 0m 55s master passed
+1 💚 javadoc 0m 51s master passed
+0 🆗 spotbugs 3m 7s phoenix-core in master has 972 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 13m 28s the patch passed
+0 hbaserecompile 23m 26s HBase recompiled.
+1 💚 compile 1m 2s the patch passed
+1 💚 javac 1m 2s the patch passed
+1 💚 checkstyle 0m 56s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 51s the patch passed
+1 💚 spotbugs 3m 15s the patch passed
_ Other Tests _
-1 ❌ unit 112m 27s phoenix-core in the patch failed.
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
180m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1302
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux af669b73ec5f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / c55b472
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/2/testReport/
Max. process+thread count 15010 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

richardantal
richardantal approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@richardantal richardantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoty stoty closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardantal richardantal richardantal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoty @richardantal