Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-6890 Remove binds parameters from QueryCompiler #1572

Closed
wants to merge 1 commit into from
Closed

PHOENIX-6890 Remove binds parameters from QueryCompiler #1572

wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Mar 3, 2023

No description provided.

@stoty stoty requested a review from richardantal March 3, 2023 18:55
@gjacoby126
Copy link
Contributor

gjacoby126 commented Mar 3, 2023 •
edited
Loading

Hmm...let's say that in the future we had better cost-based optimization -- wouldn't the parameters be relevant to choosing the best plan?

I agree they don't seem to be of much use right now.

@stoty
Copy link
Contributor Author

stoty commented Mar 4, 2023

We cab still get the parameters via StatemetrContex.getBindManager(). in that case.

If we need the whole List, we can add a getter for that to BindManager.

gjacoby126
gjacoby126 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stoty stoty closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjacoby126 gjacoby126 gjacoby126 approved these changes

@richardantal richardantal Awaiting requested review from richardantal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoty @gjacoby126