Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6974 Move PBaseColumn to test #1620

Merged
merged 3 commits into from
Jun 14, 2023
Merged

PHOENIX-6974 Move PBaseColumn to test #1620

merged 3 commits into from
Jun 14, 2023

Conversation

jinggou
Copy link
Contributor

@jinggou jinggou commented Jun 12, 2023

No description provided.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@virajjasani
Copy link
Contributor

@virajjasani
Copy link
Contributor

will merge once done and we have clean jenkins results, thanks

@stoty
Copy link
Contributor

stoty commented Jun 13, 2023

FailoverPhoenixConnectionIT is extremely flakey.

@virajjasani
Copy link
Contributor

FailoverPhoenixConnectionIT is extremely flakey.

right, by clean results, i meant for "blanks" section only :)
otherwise i agree, "unit" will likely have some flakes, that's fine.

@virajjasani virajjasani merged commit 285e13b into apache:master Jun 14, 2023
virajjasani pushed a commit that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants