-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-6178 Consider adopting the create-release scripts and process… #918
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you've been trying this out locally? Do you have a staged released that I could take a look at (just to make sure it's generating something "sane" looking?
Otherwise, just nitpicking on docs and copy-paste stuff.
Extended the docs, improved version detection heuristics, and fixed references in email template. |
I will soon release rc0 for thirdparty with the script. |
… from HBase * copy and adapt dev/create-release from HBase * remove source assembly * add binary lincenses to binary assembly * use assembly as binary distribution
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it out!
Good catch on the RAT exclusions (thought I caught something you missed, but then I saw the exclusions at the very bottom!)
… from HBase