Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Show "table not found" info in wrong query #6328

Closed
dongxiaoman opened this issue Dec 7, 2020 · 6 comments
Closed

Improvement: Show "table not found" info in wrong query #6328

dongxiaoman opened this issue Dec 7, 2020 · 6 comments
Assignees
@dongxiaoman
Labels
beginner-task Small task for new contributors to ramp up enhancement

Comments

@dongxiaoman
Copy link
Contributor

When we compose/run an adhoc query, we sometimes misspell table names.
The results from query is "Broker resource missing" instead of "table not found", which is quite misleading. It is misleading because sometimes we do run into broker down situation and has the same error.

It will be a small change but with much quality of life improvement. Think about the new users that are trying Pinot and getting such errors could turn them away.
@kishoreg
Copy link
Member

kishoreg commented Dec 7, 2020

Makes sense, do you want to take it up?

@dongxiaoman
Copy link
Contributor Author

Sure, I can help with that. It would be a start to contribute

@xiangfu0 xiangfu0 added beginner-task Small task for new contributors to ramp up enhancement labels Dec 8, 2020
@xiangfu0
Copy link
Contributor

xiangfu0 commented Dec 8, 2020

Thanks @dongxiaoman !

@shivam621311
Copy link

I would like to work on this

@malbx malbx mentioned this issue Apr 9, 2021
Merged
malbx added a commit to malbx/incubator-pinot that referenced this issue May 4, 2021
@malbx
Fix the exception thrown in the case that a specified table name does…
d73f838 
… not exist (apache#6328)
Jackie-Jiang pushed a commit that referenced this issue May 20, 2021
@malbx
Fix the exception thrown in the case that a specified table name does…
7b44624 
… not exist (#6328) (#6765)

## Description
Fix the exception thrown in the case that a specified table name does not exist (#6328).  As opposed to returning `BROKER_RESOURCE_MISSING_ERROR`, which can be a bit misleading, the code has been modified to return `TABLE_DOES_NOT_EXIST_ERROR`.

## Release Notes
The error code BROKER_RESOURCE_MISSING_ERROR (410) is no longer returned in the case that a table does not exist (e.g., misspelled table name).  In such cases the error code TABLE_DOES_NOT_EXIST_ERROR (190) will now be returned.
@vijaya-lakshmi-venkatraman
Copy link

HI,
I see that there is a merged PR associated with this issue.
Is this still open?

@Jackie-Jiang
Copy link
Contributor

@vijaya-lakshmi-venkatraman Thanks for the reminder, the issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongxiaoman dongxiaoman

Labels
beginner-task Small task for new contributors to ramp up enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kishoreg @xiangfu0 @dongxiaoman @Jackie-Jiang @shivam621311 @vijaya-lakshmi-venkatraman