-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto renew jvm default sslconext when it's loaded from files #12462
Merged
xiangfu0
merged 10 commits into
apache:master
from
zhtaoxiang:make-jvm-default-sslconext-swappable
Feb 27, 2024
Merged
auto renew jvm default sslconext when it's loaded from files #12462
xiangfu0
merged 10 commits into
apache:master
from
zhtaoxiang:make-jvm-default-sslconext-swappable
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12462 +/- ##
=============================================
+ Coverage 46.87% 61.69% +14.81%
+ Complexity 948 207 -741
=============================================
Files 1829 2437 +608
Lines 96638 133255 +36617
Branches 15656 20641 +4985
=============================================
+ Hits 45300 82209 +36909
+ Misses 48104 44998 -3106
- Partials 3234 6048 +2814
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
reviewed
Feb 22, 2024
pinot-common/src/main/java/org/apache/pinot/common/utils/tls/JvmDefaultSslContext.java
Show resolved
Hide resolved
xiangfu0
approved these changes
Feb 22, 2024
zhtaoxiang
force-pushed
the
make-jvm-default-sslconext-swappable
branch
from
February 23, 2024 00:15
045aaa5
to
879c870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #12455, also auto renew jvm default sslconext when it's loaded from files