Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto renew jvm default sslconext when it's loaded from files #12462

Merged

Conversation

zhtaoxiang
Copy link
Contributor

similar to #12455, also auto renew jvm default sslconext when it's loaded from files

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 61.69%. Comparing base (6b0cfeb) to head (879c870).
Report is 1 commits behind head on master.

Files Patch % Lines
...e/pinot/common/utils/tls/JvmDefaultSslContext.java 0.00% 37 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12462       +/-   ##
=============================================
+ Coverage     46.87%   61.69%   +14.81%     
+ Complexity      948      207      -741     
=============================================
  Files          1829     2437      +608     
  Lines         96638   133255    +36617     
  Branches      15656    20641     +4985     
=============================================
+ Hits          45300    82209    +36909     
+ Misses        48104    44998     -3106     
- Partials       3234     6048     +2814     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (?)
integration <0.01% <0.00%> (?)
integration1 <0.01% <0.00%> (?)
integration2 0.00% <0.00%> (?)
java-11 61.66% <0.00%> (+14.85%) ⬆️
java-21 61.57% <0.00%> (+14.86%) ⬆️
skip-bytebuffers-false 61.68% <0.00%> (+14.82%) ⬆️
skip-bytebuffers-true 61.55% <0.00%> (+14.90%) ⬆️
temurin 61.69% <0.00%> (+14.81%) ⬆️
unittests 61.68% <0.00%> (+14.81%) ⬆️
unittests1 46.82% <0.00%> (-0.05%) ⬇️
unittests2 27.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhtaoxiang zhtaoxiang force-pushed the make-jvm-default-sslconext-swappable branch from 045aaa5 to 879c870 Compare February 23, 2024 00:15
@xiangfu0 xiangfu0 merged commit b42010a into apache:master Feb 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants