Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable periodic rebalance as a temporary work-around for the Helix issue #4459

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

Jackie-Jiang
Copy link
Contributor

Helix issue: apache/helix#331

@mcvsubbu
Copy link
Contributor

If this work-around indeed fixes the issue, we should code this up in the controller starter and enable it using configuration so that it can be used in production if needed. The configuration can be very specific (e.g. "workaround_helix_331") so that we can drop the config once the bug is fixed.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0fded63). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4459   +/-   ##
=========================================
  Coverage          ?   65.71%           
  Complexity        ?       20           
=========================================
  Files             ?     1061           
  Lines             ?    55055           
  Branches          ?     8009           
=========================================
  Hits              ?    36179           
  Misses            ?    16248           
  Partials          ?     2628

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fded63...43acd78. Read the comment docs.

@Jackie-Jiang
Copy link
Contributor Author

@mcvsubbu This work-around is a cluster config, so if we want to enable it in production, we can simply add it into the cluster config on ZK.

@Jackie-Jiang Jackie-Jiang merged commit 1d45f87 into master Jul 25, 2019
@Jackie-Jiang Jackie-Jiang deleted the periodic_rebalance branch July 25, 2019 00:36
chenboat pushed a commit to chenboat/incubator-pinot that referenced this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants