Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream github events demo #5189

Merged
merged 15 commits into from
Apr 7, 2020
Merged

Stream github events demo #5189

merged 15 commits into from
Apr 7, 2020

Conversation

npawar
Copy link
Contributor

@npawar npawar commented Mar 27, 2020

A real world application demo of Pinot. This demo lets us query github events in realtime.

Steps to run: https://apache-pinot.gitbook.io/apache-pinot-cookbook/getting-started/recipes/github-events-stream

@npawar npawar requested a review from kishoreg March 30, 2020 18:26
@codecov-io
Copy link

Codecov Report

Merging #5189 into master will decrease coverage by 9.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5189      +/-   ##
============================================
- Coverage     66.13%   56.45%   -9.68%     
  Complexity       12       12              
============================================
  Files          1050     1055       +5     
  Lines         54117    54096      -21     
  Branches       8071     8047      -24     
============================================
- Hits          35789    30542    -5247     
- Misses        15671    21128    +5457     
+ Partials       2657     2426     -231     
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/pinot/minion/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../apache/pinot/minion/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...he/pinot/core/query/reduce/ComparisonFunction.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...ot/minion/events/EventObserverFactoryRegistry.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...t/minion/executor/TaskExecutorFactoryRegistry.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...minion/executor/ConvertToRawIndexTaskExecutor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...nion/events/DefaultMinionEventObserverFactory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...startree/executor/StarTreeAggregationExecutor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
... and 414 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb5933...fb439a4. Read the comment docs.

Copy link
Member

@kishoreg kishoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Please create another issue to move all recipes out to tools to pinot-example-apps or pinot-recipes

@npawar
Copy link
Contributor Author

npawar commented Apr 7, 2020

Minor comments. Please create another issue to move all recipes out to tools to pinot-example-apps or pinot-recipes

#5220

@npawar npawar merged commit 1baede8 into apache:master Apr 7, 2020
@npawar npawar deleted the realtime_demo branch April 7, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants