Implement ARRAYLENGTH UDF for multi-valued columns #5301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add description and sample queries please. |
kishoreg
approved these changes
Apr 26, 2020
| import org.apache.pinot.core.plan.DocIdSetPlanNode; | ||
|
|
||
|
|
||
| public class LengthTransformFunction extends BaseTransformFunction { |
There was a problem hiding this comment.
Add java docs with a sample query.
|
|
||
|
|
||
| public class LengthTransformFunction extends BaseTransformFunction { | ||
| public static final String FUNCTION_NAME = "length"; |
There was a problem hiding this comment.
Since this applies to multi-valued column, It might be better to name this array_length or cardinality.
https://prestodb.io/docs/current/functions/array.html
There was a problem hiding this comment.
Thanks for the suggestion. Changed this to arrayLength so people do not confuse it with the length function for strings.
bozhang2820
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support pushdown of Presto SQL's cardinality() function.
Sample queries:
SELECT COUNT(*) FROM table WHERE arrayLength(mvColumn) > 2SELECT COUNT(*) FROM table GROUP BY arrayLength(mvColumn)SELECT MAX(arrayLength(mvColumn)) FROM table