Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inbuilt transform functions #5312

Merged
merged 4 commits into from
Apr 28, 2020

Conversation

npawar
Copy link
Contributor

@npawar npawar commented Apr 28, 2020

Wiring the FunctionExpressionEvaluator with the ExpressionEvaluatorFactory to be able to execute inbuilt transform functions.
Added 2 simple time transformation examples.

Immediate next steps:

  1. Exhaustively add a lot of time transformation functions. Can be a good beginner/first task

Future steps:

  1. Ability to plug in user defined custom functions - annotation based function registering
  2. Ability to use these simple transform functions as query time udfs - Introduce a udf wrapper that can call these simple transform functions on every row during query

@npawar npawar requested a review from kishoreg April 28, 2020 01:00
@npawar
Copy link
Contributor Author

npawar commented Apr 28, 2020

#2756

@npawar
Copy link
Contributor Author

npawar commented Apr 28, 2020

@yupeng9 FYI, you can use this to add functions related to geo spatial for #5280

@codecov-io
Copy link

codecov-io commented Apr 28, 2020

Codecov Report

Merging #5312 into master will decrease coverage by 9.38%.
The diff coverage is 61.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5312      +/-   ##
==========================================
- Coverage   66.23%   56.84%   -9.39%     
==========================================
  Files        1066     1071       +5     
  Lines       54552    54513      -39     
  Branches     8128     8129       +1     
==========================================
- Hits        36132    30989    -5143     
- Misses      15774    21104    +5330     
+ Partials     2646     2420     -226     
Impacted Files Coverage Δ
...e/pinot/broker/api/resources/PinotBrokerDebug.java 0.00% <ø> (-76.67%) ⬇️
.../BrokerResourceOnlineOfflineStateModelFactory.java 41.86% <ø> (-13.96%) ⬇️
...quota/HelixExternalViewBasedQueryQuotaManager.java 64.84% <ø> (-3.04%) ⬇️
...roker/requesthandler/BaseBrokerRequestHandler.java 20.10% <ø> (-59.25%) ⬇️
...rg/apache/pinot/broker/routing/RoutingManager.java 66.53% <ø> (-14.62%) ⬇️
...ting/instanceselector/InstanceSelectorFactory.java 71.42% <ø> (ø)
...er/routing/segmentpruner/SegmentPrunerFactory.java 83.33% <ø> (ø)
...outing/segmentselector/SegmentSelectorFactory.java 60.00% <ø> (ø)
...oker/routing/timeboundary/TimeBoundaryManager.java 87.50% <ø> (ø)
...mmon/assignment/InstanceAssignmentConfigUtils.java 67.50% <ø> (-5.00%) ⬇️
... and 511 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e8d96...a9c6aaf. Read the comment docs.

@yupeng9
Copy link
Contributor

yupeng9 commented Apr 28, 2020

@yupeng9 FYI, you can use this to add functions related to geo spatial for #5280

Great. Will try this out. Thanks.

@npawar npawar merged commit b0ad7ca into apache:master Apr 28, 2020
@npawar npawar deleted the inbuilt_transform_functions branch April 28, 2020 16:24
@npawar
Copy link
Contributor Author

npawar commented May 7, 2020

#5352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants