In SegmentPurger, use table config to generate the segment #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snleee
approved these changes
May 1, 2020
| @@ -39,7 +41,7 @@ public static MinionContext getInstance() { | |||
|
|
|||
| private File _dataDir; | |||
| private MinionMetrics _minionMetrics; | |||
| private String _minionVersion; | |||
| private ZkHelixPropertyStore<ZNRecord> _helixPropertyStore; | |||
There was a problem hiding this comment.
+1 for this!
I thought of fetching table config calling controller API. This approach is much simpler :)
|
All the indexing and partition info are stored in the table config. Without the table config, purged segment will lose the indexing and partition info, which could cause performance issue. In the following pr, we will enforce all segment creation to provide table config and schema to guarantee the consistent behavior.
Jackie-Jiang
force-pushed
the
purge_take_table_config
branch
from
df1f03f
to
4db2ecd
Compare
Yeah, need to modify the test to plug in the property store |
Codecov Report
@@ Coverage Diff @@
## master #5325 +/- ##
==========================================
- Coverage 66.07% 56.85% -9.23%
==========================================
Files 1072 1072
Lines 54562 54552 -10
Branches 8139 8137 -2
==========================================
- Hits 36052 31015 -5037
- Misses 15865 21105 +5240
+ Partials 2645 2432 -213
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the indexing and partition info are stored in the table config.
Without the table config, purged segment will lose the indexing and partition info, which could cause performance issue.
In the following pr, we will enforce all segment creation to provide table config and schema to guarantee the consistent behavior.