Clean up all integration tests and standardize the creation of schema, table config and segments #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5385 +/- ##
==========================================
- Coverage 56.91% 56.88% -0.03%
==========================================
Files 1089 1089
Lines 55778 55781 +3
Branches 8365 8366 +1
==========================================
- Hits 31746 31733 -13
- Misses 21522 21532 +10
- Partials 2510 2516 +6
Continue to review full report at Codecov.
|
Jackie-Jiang
force-pushed
the
integration_tests_clean_up
branch
2 times, most recently
from
2b518e7
to
cf613cc
Compare
…, table config and segments - Create schema and table config based on the settings in the BaseClusterIntegrationTest - Remove the methods with huge arguments list - Always use the schema and table config in the cluster to create the segments - Simplify the cluster setup methods The following integration tests are removed: - DefaultCommitterRealtimeIntegrationTest: Merged into LLCRealtimeClusterIntegrationTest - PinotURIUploadIntegrationTest: Already covered in the module-level FileUploadDownloadClientTest ControllerPeriodicTasksIntegrationTest is refactored (was not running before because the wrong test name '*Tests') RealtimeStressTest is removed as it is the same as BenchmarkRealtimeConsumptionSpeed
Jackie-Jiang
force-pushed
the
integration_tests_clean_up
branch
from
cf613cc
to
ddabdfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following integration tests are removed:
ControllerPeriodicTasksIntegrationTest is refactored (was not running before because the wrong test name '*Tests')
RealtimeStressTest is removed as it is the same as BenchmarkRealtimeConsumptionSpeed