Adding integration test for null handling from realtime source #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Aug 16, 2020
pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java
Outdated
Show resolved
Hide resolved
...tion-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ation-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTest.java
Outdated
Show resolved
Hide resolved
...tion-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian (Jackie) Jiang <17555551+Jackie-Jiang@users.noreply.github.com>
| @@ -241,6 +242,10 @@ protected IngestionConfig getIngestionConfig() { | |||
| return null; | |||
| } | |||
|
|
|||
| protected boolean getNullHandlingEnabledConfig() { | |||
There was a problem hiding this comment.
(nit)
Suggested change
| protected boolean getNullHandlingEnabledConfig() { | |
| protected boolean getNullHandlingEnabled() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an end-end integration test for creating a Pinot table with Kafka records including null values and running queries against this table (with the IS NOT NULL predicate). Related to #4230
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
No
Does this PR fix a zero-downtime upgrade introduced earlier?
No
Does this PR otherwise need attention when creating release notes?
No