Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Eclipse Milo to 0.3.7 #158

Merged
merged 1 commit into from
May 27, 2020
Merged

Updated Eclipse Milo to 0.3.7 #158

merged 1 commit into from
May 27, 2020

Conversation

patrickse
Copy link
Contributor

Eclipse Milo 0.3.7 supports relaxed nonce validation when not using protected credentials. It's needed to talk to development PLC from Schneider Electric.

eclipse/milo@35ee06e

Signed-off-by: Patrick Sernetz psernetz@cad-schroer.de

Signed-off-by: Patrick Sernetz <psernetz@cad-schroer.de>
@JulianFeinauer
Copy link
Contributor

Thanks @patrickse ! Do we have integration tests for milo or did you test the code already?

@patrickse
Copy link
Contributor Author

I am not aware of any integration test. We've changed the dependency and deployd it to our platform. It looks ok for now. How could I implement an integration test?

@JulianFeinauer
Copy link
Contributor

JulianFeinauer commented May 25, 2020

Good question, indeed. But good to know that it works for you. @nalim2 we should definetly have a look there. Probably we could start an OPC Server and start a Client and just do some sending. Probably even using the awesome TestContainers Project?

@nalim2
Copy link
Contributor

nalim2 commented May 25, 2020

Yeah i think to include there a Sample Server should be a good idea. I would first just integrate a Milo example server and would transfere the ManualTest class to an integration test or what you mean by the TestContainers Project?

If there would be an alternativ server it would be better to get possible specification problems

@nalim2
Copy link
Contributor

nalim2 commented May 25, 2020

But just the updated versions lgtm

@nalim2 nalim2 merged commit 44790eb into apache:develop May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants