-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address string with tokenisation, refactoring, loopback s7 c example added. s7c write variable works #233
Conversation
…iler warnings on hurz cast and degloablised hurz. Rewrote the connection string parser to use tokenisation rather than walking pointer. hello_world_s7.c corrected some printfs and allowed cli args. transport_tcp.c fixed compile warning on printf. hello-wolrd-s7 now working
…sue with s7 payload data item offset to resolve
@thomas169 is this still a WIP/Draft pull request? If yes I can mark it as such |
Yeh still WIP. Write arrays (e.g. UINT[2]) work, but not sure the way I implemented this is how it was intended to be. As write response items are still unchecked / unused it's still draft. |
… to write responces in sm_write.c, correct instalisation of request values in packets.c, naming consistency in sm_read.c.
Hi Thomas, a general question ... could you be so kind and sign up for the dev@plc4x.apache.org list and tell us a bit about what you're up to? Chris |
I already signed up, but sure, will message mailing list. |
out of curiosity: as you (@thomas169) marked it for ready for review and added changes to it 7 days after: is it done done yet? If so maybe I would suggest that @ottobackwards or @chrisdutz should do a final review then and merge et, as im not confident enough in the c-world :D |
its done in relation to the title. But any commits to my fork also come into this PR, hence the later 3 commits. |
3a) Added I think most todos in write.c, drive_s7_packet.c, driver_s7_sm_write.c
Note write response return values are not checked (or used), nor tested with arrays of a write type, (think it will not work)