Feature/top level item spliting #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
force-pushed
the
feature/TopLevelItemSpliting
branch
2 times, most recently
from
a0c3607
to
9e25460
Compare
|
So do I get this correctly, that with the SingleItemToSingleRequestProtocol is a simplified and distilled version of what I did in the S7 protocol? |
|
@chrisdutz yep, kinda :) |
|
in theory we could just insert it into ADS and modbus and they could support unoptimized multiple fields till that is implemented. But this all needs testing though. The PR is just to keep this work visible as the branch was several months behind. |
RuntimeExceptions with log statements.
asfgit
force-pushed
the
feature/TopLevelItemSpliting
branch
from
86041d3
to
5951fc5
Compare
asfgit
force-pushed
the
feature/TopLevelItemSpliting
branch
from
5951fc5
to
327cc6f
Compare
sruehl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generic top item level splitting which splits a batch request into multiple requests so protocols can use this layer where batching isn't possible at all.