Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLC4X-299] Fix for array handling in the Kafka source connector #255

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

hutcheb
Copy link
Contributor

@hutcheb hutcheb commented Jun 3, 2021

Still need to do something with the error so that the test fails when an error occurs.
As well as fix the array handling problem.

@hutcheb hutcheb changed the title [PLC4X-299] Add test case for array handling, as well as log the error [PLC4X-299] Fix for array handling in the Kafka source connector Jun 4, 2021
@hutcheb hutcheb marked this pull request as ready for review June 4, 2021 08:56
@hutcheb hutcheb merged commit dfdecde into develop Jun 4, 2021
@hutcheb hutcheb deleted the bug/kafka_array_handle branch June 4, 2021 11:28
RalfBarkow pushed a commit to RalfBarkow/plc4x that referenced this pull request Jun 5, 2021
* commit 'dfdecde0dfc881b9da6586633c96c29e4d8e6962': (2143 commits)
  [PLC4X-299] Fix for array handling in the Kafka source connector (apache#255)
  plc4j: fixed some bugs and code smells in plc4j-spi
  - Ensured our website will continue to be published
  - Fixed some of the most critical issues reported for this file
  - Fixed some of the most critical issues reported for this file
  - Added some more configuration options to prevent sonarcloud from complaining - Tried something else to make sonarcloud happy
  - Tried fixing some issues related to plc4c printf statements for long types.
  - Added support for a new "unknown" field type
  - Another attempt to get the c code-analysis working
  - Another attempt to get the c code-analysis working
  - Another attempt to get the c code-analysis working
  - Moved the definition of the build-wrapper-output to the main pom.
  - Added a test to get the c code-coverage working
  plc4j: replaced Thread.sleep() with timer().schedule()
  plc4j: fixed unintended use of await
  plc4j: fixed unintended use of await
  - Added a hacky tool that in case of an enabled "jenkins-build", renames the cmake binary to cmakeOrig and generates a script that calls the sonar build-wrapper before calling cmakeOrig
  plc4j: fixed DoS sonar issues
  plc4j: fixed DoS sonar issues
  - Disabled the plc4c anaysis for now in order to see if the plc4go analysis works.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant