Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide connection metadata #32

Merged
merged 5 commits into from
Oct 26, 2018
Merged

Provide connection metadata #32

merged 5 commits into from
Oct 26, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 26, 2018

As discussed in the mailing list, connection capabilities should be obtained via metadata and remove Optionals from the PlcConnection.

Copy link
Contributor

@sruehl sruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@asfgit asfgit merged commit fc347aa into master Oct 26, 2018
@asfgit asfgit deleted the feature/connection-metadata branch October 26, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants