Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple mock driver #38

Merged
merged 9 commits into from
Nov 2, 2018
Merged

Add simple mock driver #38

merged 9 commits into from
Nov 2, 2018

Conversation

JulianFeinauer
Copy link
Contributor

I decided to make a new PR (in concurrence to #37 ) as this is the solution we need to test our code.
The idea behind this mock driver is to allow testing WITHOUT changing the field adresses in your code you want to test (currently they have to be hardcoded for some reasons).
This is not possible with the test driver and so I suggest to merge this pr and close #37 if you agree.
@chrisdutz would be good to have your feedback on that (I know there are many mock drivers.. but I think there is nothing (yet) to solve this problem described above).

PS.: kittens

@JulianFeinauer
Copy link
Contributor Author

Got green light from @chrisdutz and will merge now 👍

@JulianFeinauer JulianFeinauer merged commit e39cae0 into master Nov 2, 2018
@asfgit asfgit deleted the add-simple-mock-driver branch November 23, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant