S7: changed byteLength and blockNumber from short to int

[timbo2k]

byteLength and blockNumbers had been to small using short for possible values
added some tests for out of range values
did successful manual test with scraper and updated commited yml-config

[chrisdutz]

Hi Tim,
it seems that the block number still is a short. It's just the byteOffset that is 21 bits big.
Could you please adjust your PR to this?

Chris

[timbo2k]

Hi Chris

I think there are also block number > 32000 possible (see attached screenshot from a recently added block with the number 50000), so Short will not be enough in my opinion, this maybe depends on the part of used S7 device --> I wrote a ToDo for that in the code

[chrisdutz]

Argh ... dammit ... you are right. The protocol only transfers 2 bytes (1 short). However you are correct that Java shorts are signed and the protocol uses unsigned, so you are correct that we should change this to int ... however we now have to check if the protocol code is correct everywhere.

[chrisdutz]

Ok .. so I double-checked the Protocol implementaton ... on the writing side, we're safe as "writeShort(int)" works like a charm and we currently don't parse "AnyItems", so no way we could parse it wrong. Guess we can merge this.

Thanks for contributing :-)

👍

[timbo2k]

I just ran a test vs our physical device with had been successful - so everything seems to be Ok