Feature/alternate plc4 x 108 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed the PlcConnection "parse" method to "prepareField" - Added a "ping" method to the PlcConnection (which returns a CompletableFuture<Void>) - Removed the getInetSocketAddress method
- Fixed two broken driver implementations (Dummy and Mock Driver)
- Implemented the "ping" method for different base types.
|
@chrisdutz thank you for the PR! I will try to review it this week and start some tests with our S7 PLC here, to see if it works. |
sruehl
reviewed
Apr 10, 2019
| @Override | ||
| public CompletableFuture<Void> ping() { | ||
| CompletableFuture<Void> future = new CompletableFuture<>(); | ||
| future.completeExceptionally(new PlcUnsupportedOperationException("The connection does not support pinging")); |
There was a problem hiding this comment.
I would suggest to use https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/concurrent/CompletableFuture.html#failedFuture(java.lang.Throwable) here if possible.
There was a problem hiding this comment.
Argh ... was looking for something like that ... strangely I must have missed it :-) ... of course ... will update that.
There was a problem hiding this comment.
Ha! ... I knew there was something ... if I used the failedFuture method, we would have to bump up the Java level to 9 which I wasn't planning on doing just for this one convenience method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in this alternate implementation, I added a "ping" method to the default API and moved the code for the TCP ping into the classes actually involved in TCP (with options for other base types - serial, udp, raw-socket, test, ...).
Please review.