Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for information loss on footnotes/endnotes within XWPFRun.toString #3

Closed
wants to merge 1 commit into from

Conversation

akhikhl
Copy link

@akhikhl akhikhl commented Jun 12, 2013

Dear Apache POI Team,

Please consider a problem: whenever MS-Word document with footnotes/endnotes is being parsed with XWPFWordExtractor, information on the location of footnote/endnote references is lost. This information loss is clearly observed in, for example, Apache Tika output.

To reproduce a problem, please insert the following code to TestXWPFWordExtractor.testFootnotes:

    java.io.FileWriter w = new java.io.FileWriter(new java.io.File(System.getProperty("user.home"), "footnotes.output.txt"));
    try {
      w.write(extractor.getText());
    } finally {
      w.close();
    }

then run tests and inspect the content of "footnotes.output.txt" - it contains "Eto ochen prostoy text so snoskoy", where between "prostoy" and "text" there should be a footnote reference (and it is lost).

SOLUTION:
I suggest to introduce additional markup like [footnoteRef:num], [endnoteRef:num], which will allow applications to correctly render footnote references.

Please, see commit details.

@Gagravarr
Copy link
Contributor

Thanks, committed in r1492308. (That should mirror through to git shortly)

Gagravarr added a commit that referenced this pull request Jun 12, 2013
ischindl pushed a commit to ischindl/poi that referenced this pull request Jul 9, 2014
@asfgit asfgit closed this in 5d79479 Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants