[Flaky Test]: Fix flaky test TestMaxPendingChunkMessages() #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gleiphir2769
changed the title
Gleiphir2769
force-pushed
the
fix_flaky_test
branch
from
267a39b
to
4e2f433
Compare
Gleiphir2769
force-pushed
the
fix_flaky_test
branch
from
4e2f433
to
72f8e80
Compare
RobertIndie
requested changes
Apr 24, 2023
pulsar/message_chunking_test.go
Outdated
Comment on lines
565
to
573
| producerImpl.internalSingleSend( | ||
| mm, | ||
| msg.Payload, | ||
| &sendRequest{ | ||
| callback: func(id MessageID, producerMessage *ProducerMessage, err error) {}, | ||
| msg: msg, | ||
| }, | ||
| uint32(internal.MaxMessageSize), | ||
| ) |
There was a problem hiding this comment.
We need to flush the producer after sending the message. Or handle the callback of the sendRequest.
There was a problem hiding this comment.
We need to flush the producer after sending the message
OK, I will fix it.
|
@RobertIndie Can you retake a look? |
|
Ping @RobertIndie. |
RobertIndie
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
Motivation
Old TestMaxPendingChunkMessages() uses the concurrent message publish to make the consumer discard unavailable chunk. And it's flaky.
So the
sendSingeChunk()is introduced to manual create scenarios where old chunks should be discarded.Modifications
TestMaxPendingChunkMessages()Verifying this change