Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify TLS ciphers an min/max TLS version #1041

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

dinghram
Copy link
Contributor

My company requires specific cipher suites and control over TLS version used for security.

Modifications

ClientOptions now has TLSCipherSuites, TLSMinVersion, and TLSMaxVersion. These are used when creating tls.Config objects.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage, simple pass-along variables to tls.Config objects.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes)
  • The schema: (don't know)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)
  • If a feature is not applicable for documentation, explain why? Simple pass-along features with comments.
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljmarshall michaeljmarshall merged commit 5f82516 into apache:master Jun 27, 2023
@michaeljmarshall michaeljmarshall added this to the v0.11.0 milestone Jun 27, 2023
dinghram added a commit to dinghram/pulsar-client-go that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants