Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue 259][pulsar-client-go] fix fail to add batchbuilder #260

Merged
merged 1 commit into from
May 22, 2020
Merged

[Issue 259][pulsar-client-go] fix fail to add batchbuilder #260

merged 1 commit into from
May 22, 2020

Conversation

yarthur1
Copy link
Contributor

Fixes #<Issue 259>

Motivation

after fail to add batchbuilder, should callback and release publishSemaphore.and fix the batch and single send logic

merlimat
merlimat approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is much clearer.

The error condition though shouldn't have happened, since the 2nd time the batchbuilder.add() would succeed since the batch will be empty.

@merlimat merlimat added this to the 0.1.1 milestone May 22, 2020
@merlimat merlimat merged commit 416c5f6 into apache:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees

@yarthur1 yarthur1

Labels
type/bug
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@yarthur1 @merlimat