Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 350] fix panic on receiverQueueSize set to -1 #361

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

reugn
Copy link
Contributor

@reugn reugn commented Sep 5, 2020

Fixes #350

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no

@wolfstudy wolfstudy requested review from wolfstudy and merlimat and removed request for wolfstudy October 9, 2020 01:59
@wolfstudy wolfstudy self-requested a review October 9, 2020 01:59
@wolfstudy wolfstudy added this to the 0.3.0 milestone Oct 9, 2020
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit 7fb79b7 into apache:master Oct 9, 2020
@reugn reugn deleted the issue_350 branch November 8, 2021 07:32
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
…e/pulsar-admin-go#246) (apache#361)

Add command topic max unacked messages per subscription:

* pulsarctl topics get-max-unacked-messages-per-subscription [topic]
* pulsarctl topics set-max-unacked-messages-per-subscription [topic] -m [max]
* pulsarctl topics remove-max-unacked-messages-per-subscription [topic]
tisonkun pushed a commit to tisonkun/pulsar-client-go that referenced this pull request Aug 15, 2023
…e/pulsarctl#246) (apache#361)

Add command topic max unacked messages per subscription:

* pulsarctl topics get-max-unacked-messages-per-subscription [topic]
* pulsarctl topics set-max-unacked-messages-per-subscription [topic] -m [max]
* pulsarctl topics remove-max-unacked-messages-per-subscription [topic]
tisonkun pushed a commit that referenced this pull request Aug 16, 2023
…e/pulsarctl#246) (#361)

Add command topic max unacked messages per subscription:

* pulsarctl topics get-max-unacked-messages-per-subscription [topic]
* pulsarctl topics set-max-unacked-messages-per-subscription [topic] -m [max]
* pulsarctl topics remove-max-unacked-messages-per-subscription [topic]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReceiverQueueSize -1 leads to crash
2 participants