Deduplicate user provided topics before using them #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If user provided retry topic is same with consumer topic
consumer.Close()
, only the 2th consumer will be closed directly, consumer 1st is still active, there are potential memory leak.Reproducation
issue: consumer 1 created but not close directly, it will be closed before client closing.
log
Cause
MultiTopicConsumer is using
map[topic]consumer
to manage consumers, but in the above case, only 2th consumer will becorresponded with the topic, the 1st dosen't since map overwriting, it means 1st isn't managed by multiTopicConsumer , see consumer_multitopic.go#L66
Motivation
TreeSet
topics implementation, see ConsumerConfigurationData.java#L56Modifications
distinct
utility function to deduplicate user provided topicsVerifying this change