[Issue 729]stop ticker when create producer failed #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoothzj
approved these changes
Feb 17, 2022
wolfstudy
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Thanks @NaraLuwan work for this, just a little comments, please check
| @@ -145,6 +145,7 @@ func newPartitionProducer(client *client, topic string, options *ProducerOptions | |||
| } | |||
| err := p.grabCnx() | |||
| if err != nil { | |||
| p.batchFlushTicker.Stop() | |||
There was a problem hiding this comment.
The grabCnx() is called in two places in total, except here in thereconnectToBroker() logic, it looks like we need the same fix.
There was a problem hiding this comment.
but newTicker() is called only with newPartitionProducer(), i don't think we need to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: [#729 ]
Motivation
I received an alarm indicating that the server load was too high, used the pprof tool to locate the problem and determined that the cause was a ticker leak while a large number of producer creating failed.
Here are some screenshots to show it:
Modifications
stop ticker when create producer failed