Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support consumer client memory limit #991

Merged
merged 9 commits into from
Mar 23, 2023

Conversation

Gleiphir2769
Copy link
Contributor

Master Issue: #927

Motivation

This is part of the work for PIP 74 in go client.

More details in #927 .

Modifications

  • Consumer adds memory limit relate logic.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)

pulsar/consumer_partition.go Outdated Show resolved Hide resolved
pulsar/consumer_partition.go Outdated Show resolved Hide resolved
pulsar/consumer_test.go Outdated Show resolved Hide resolved
@shibd shibd merged commit 20291f5 into apache:master Mar 23, 2023
@Anonymitaet
Copy link
Member

Anonymitaet commented Apr 18, 2023

Hi @shibd, thanks for introducing this great feature!

========================================

As we discussed just now, for the doc side:

✅ Pulsar feature matrix

I've ticked the box of "Memory Limits" for Go.

✅ Pulsar client docs

🌈 Collobration way

To add docs for it, feel free to choose your preferred method (either way works for me):

  • You provide tech inputs to me. I'll write docs based on them and request your review. Or

  • You submit a PR to the pulsar-site repo directly and request my review.

🌈 TO-DO tasks

  1. Create a tab for Go and a topic named "Set memory limits" in work with clients. It should explain:
  • What is it?
  • How to use it? (e.g., any considerations? Sample code, etc)

image

  1. This doc is only added to NEXT (submit a PR here) since this feature is server-independent.

========================================

Feel free to reach out to me if you have questions. TIA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants